search

Ohmbrewer / ohmbrewer

The web application for a happy brew day.
http://ohmbrewer.github.io
0 stars 0 forks source link

Refactors our Schedule Gantt chart to use the google_visualr gem. #94

Closed kyleoliveira closed 8 years ago

kyleoliveira commented 8 years ago

Adds visualization for ramping tasks and simplifies the calculation of start/end times for tasks by simply providing the duration and letting Google Charts figure out things based on dependencies.

Right now, you'll notice that the Gemfile is pointing at a GitHub repo I've made by forking google_visualr. This is because the Google Charts api changed since the last time the gem maintainer updated the gem (last September). I figured out what needs to be fixed to get it rolling again, and I've put in a pull request (winston/google_visualr#102), so hopefully that'll get pulled into the mainline sometime soon. When/if that happens, we'll just remove the git reference and set the gem to the correct version.

This change should make it easier/cleaner to work with Google Charts going forward, which is going to be important when we start implementing the dashboard.

@kathomas921 Take a look at this when you get a chance, and let me know what you think. I rearranged the actual chart elements a little bit, but I feel like it provides more useful information this way. You should try it out combinations of off/on tasks, RunThermostatTasks, and one or more tasks that start on Ramping, just to see what happens.

kyleoliveira commented 8 years ago

Added #95 as a reminder to swap the gem.

kyleoliveira commented 8 years ago

@kathomas921 Please make sure to take a look at this. If I don't get any negative feedback, I'm planning to merge it before the end of the weekend.