Closed ankit-m closed 8 years ago
I noticed that no changes to the options page were committed. I am wondering where the user will insert the Google API key... Could you tell me? Could you show me a screenshot of the options page?
- Google allows 128 strings to translated in one call. This forces us to make multiple API calls for one page (i.e. if the number of words is greater than 128). Even if a single API call fails, no translations will be shown.
Wouldn't it make more sense to show the translations corresponding to the successful API calls?
@Ceilican: There is already support for the user to save the key
Thanks!
Thanks @rohankatyal29 !
@Ceilican It is because Promise.all()
function. It is fast fail function and throws as soon as any one promise fails. I will still try and retrieve the partial results.
This PR adds support for Google Translate API.
Notes