search

OiWorld / MindTheWord

An extension for Google Chrome that helps people learn new languages while they browse the web.
43 stars 47 forks source link

Statistics tab [WIP] #141

Closed rohankatyal29 closed 8 years ago

rohankatyal29 commented 8 years ago
screen shot 2016-06-21 at 3 56 03 pm screen shot 2016-06-21 at 3 56 09 pm
ceilican commented 8 years ago

Hi Rohan! I liked the statistics tab! But I think statistic information should not be shown in the "translation-settings" tab, because it breaks the modularisation of the options page UI. Could you revert the changes to the "translation-settings" tab and move the statistical information that you had added in it to the new statistics page? I will merge this PR after this is done.

ceilican commented 8 years ago

You asked what other kinds of statistics you could add. Here is an idea: number of distinct translated words.

rohankatyal29 commented 8 years ago

@Ceilican: Those are two different screenshots in the description. The statistic information is under a different statistics tab only.

I am attaching the complete screenshots:

screen shot 2016-06-21 at 9 58 24 pm screen shot 2016-06-21 at 9 58 30 pm
ceilican commented 8 years ago

Another idea: number of characters translated with Google/Bing/Yandex in the current month. This is relevant to compare with the translation API's monthly limits.

rohankatyal29 commented 8 years ago

@Ceilican: Interesting, will look into both of those!

We can probably display the number of translated words on each HTML page as well?

ceilican commented 8 years ago

I know that there were two different screenshots. My comment still applies. I'm very happy with the second screenshot (i.e. the new "statistics" tab). But I think the changes shown in the first screenshot are bad. Statistical information should not be shown in the "Translation" tab. It pollutes the UI and makes the UI more confusing and less structured.

I like the idea of having word count per pattern, but these words counts should nevertheless be shown in the "statistics" tab, not in the "translation" tab.

rohankatyal29 commented 8 years ago

I misunderstood what you were saying, will make the necessary changes

ceilican commented 8 years ago

We can probably display the number of translated words on each HTML page as well?

I'm not sure I fully understand your feature proposal.

this could be counted, but instead of displaying it in the HTML page itself, I think it would be better to display it somewhere less intrusive to the user. Maybe in a popup shown when the user requests the statistical info via a context menu? This has to be thought carefully.

rohankatyal29 commented 8 years ago

Updated UI

screen shot 2016-06-21 at 10 24 58 pm
ceilican commented 8 years ago

Great! Now the UI looks perfect.

But the PR become unmergeable through Github's automatic merging mechanism. Could you rebase?

rohankatyal29 commented 8 years ago

@Ceilican: the code can be merged now

ceilican commented 8 years ago

Thanks!

ankit-m commented 8 years ago

@rohankatyal29 please make sure that you make new branches out of the latest code committed, so that the changes we make are not reverted by the others commit.

rohankatyal29 commented 8 years ago

@ankit-m: I always rebase with the upstream master before pushing, so that shouldn't be a problem

rohankatyal29 commented 8 years ago

@Ceilican: For distinct words I would have to maintain an array of every word that has been translated till the data is reset, wouldn't that occupy way too much space in the local storage?

ceilican commented 8 years ago

@Ceilican: For distinct words I would have to maintain an array of every word that has been translated till the data is reset, wouldn't that occupy way too much space in the local storage?

Possibly. How much space do we have available?

Maintaining such an array of words only to be able to count distinct words is probably not worth the space overhead, but we could think of other interesting features if we had such an array. For example, we could show this array to the user, ordered by how frequently they are translated (so, in fact, we would need a hashmap, instead of an array). This would allow the user to review the translations. There could be some buttons allowing the user to easily include words from this array into the list of learned words, into the blacklist, into difficulty buckets and so on...

If we think about all the interesting features that such an array would allow us to have, maybe it would be worth having such an array stored in the storage.

Could you think about this?

rohankatyal29 commented 8 years ago

That makes sense, we could probably do something like that. Let me think more about this and see what I can come up with.