search

OiWorld / MindTheWord

An extension for Google Chrome that helps people learn new languages while they browse the web.
43 stars 47 forks source link

closes #95 #162

Open rohankatyal29 opened 8 years ago

rohankatyal29 commented 8 years ago

95

rohankatyal29 commented 8 years ago

@ankit-m - what is this check that is failing?

ankit-m commented 8 years ago

@rohankatyal29 can you check it on your local machine?

ankit-m commented 8 years ago

The TravisCI log shows that PhantomJS did not load. My guess is that mutation observer is causing it to fail. Is Mutation Observer supported in Chrome only? The test environment uses PhantomJS as it is headless.

rohankatyal29 commented 8 years ago
screen shot 2016-07-22 at 12 49 27 pm

Can we just ignore this?

ankit-m commented 8 years ago

@rohankatyal29 I don't think this will be a good idea. Because if we merge this, all Travis CI checks will fail from now on, defeating its purpose. Would it be possible to find a workaround?

Karma does support Chrome and Chrome Canary but with the downside that every test will open a window of Chrome. But I don't know if it will work on Travis (as it is only terminal).

As an alternative, maybe we can delay this change until headless Chrome is released. It is supposed to be out soon. https://news.ycombinator.com/item?id=11839303

rohankatyal29 commented 8 years ago

@ankit-m, @Ceilican - Maybe we can merge this is in the production version when we release it to the users, but not put in the dev repo. What do you think?

ceilican commented 8 years ago

@rohankatyal29 I don't think this will be a good idea. Because if we merge this, all Travis CI checks will fail from now on, defeating its purpose. Would it be possible to find a workaround?

I think any workaround would have to be found in the way we do the tests. We shouldn't hack our solutions just because they are not testable with current testing technology. Testing is very important, but it is secondary to the main goal.

@ankit-m, @Ceilican - Maybe we can merge this is in the production version when we release it to the users, but not put in the dev repo. What do you think?

That would be inconvenient to maintain.