search

OiWorld / MindTheWord

An extension for Google Chrome that helps people learn new languages while they browse the web.
43 stars 47 forks source link

redesign options page. #168

Closed ankit-m closed 8 years ago

ankit-m commented 8 years ago

new improved ui

ceilican commented 8 years ago

Thanks!

ceilican commented 8 years ago

@ankit-m One of the tests is failing now. It is clearly a problem in the test, not in the code. The test needs to be fixed.

ankit-m commented 8 years ago

@Ceilican the tests aren't wrong. In fact, I set the test to see whether default translator is set Yandex. In the latest set of changes, we removed default translator. Hence it shows the error.

err_test

ankit-m commented 8 years ago

I will make the changes in the test and raise a PR.

ceilican commented 8 years ago

In fact, I set the test to see whether default translator is set Yandex. In the latest set of changes, we removed default translator. Hence it shows the error.

Yes, that's what I meant.