search

OiWorld / MindTheWord

An extension for Google Chrome that helps people learn new languages while they browse the web.
43 stars 47 forks source link

[Enhancement] Saving to user dictionary added #84

Closed Stormteller closed 8 years ago

Stormteller commented 8 years ago

Now user can save words to the dictionary using context menu, like in #83. User can save only translated words.

P.S. I've copy-pasted @rohankatyal29 changes from #83 because they weren't pulled.

Stormteller commented 8 years ago

@Ceilican What about remind this words to user in some way? And I also noticed that on the same page the same word is highlighted. Is it a bug?

ankit-m commented 8 years ago

@Stormteller don't add so many commits, especially with reverts. Rebase your branch and squash all commits into one. This makes it easy to see all the changes.

You don't copy paste the changes made in someone else's pull request which is open. Just add your changes.

ceilican commented 8 years ago

Thanks, @Stormteller ! I pulled some previous PRs, and your PR became unmergeable, could you please rebase it, so that I can merge it?

Also, could you include a screenshot of the feature here?