search

OiWorld / MindTheWord

An extension for Google Chrome that helps people learn new languages while they browse the web.
43 stars 47 forks source link

add update key button and ui fixes #86

Closed ankit-m closed 8 years ago

ankit-m commented 8 years ago

Adding the Yandex key field was rather unintuitive. The event listener was blur. If someone would copy paste the key, they would have to click somewhere else to save the key.

Update button makes the design more intuitive.

ui_fixes

Also, there are some changes in the html structure of Create New Translation Configuration and Translation Settings according to Bootstrap Docs.

ceilican commented 8 years ago

I agree that "blur" is not good, for the reasons you mentioned. But, on the other hand, buttons are old-fashioned in terms of GUI design. We don't see them so much anymore nowadays.

The ideal solution, I think, would have no button, but a better event handling mechanism.

ankit-m commented 8 years ago

@Ceilican I agree that the button looks old-fashioned, but it does give the user positive response when he updates the key. Another case where it is useful, is when the key they entered is wrong, and they want to edit it. Update gives a confirmation that I have changed/updated the key. This was my reasoning behind adding this button.

The ideal solution, I think, would have no button, but a better event handling mechanism. I will look for other mechanisms.

ceilican commented 8 years ago

I will look for other mechanisms.

Ok. Let me know if you find an interesting mechanism.

By the way, I think GSoC application page has a buttonless mechanism for storing updated data. The application period for students will open on Monday, and then you will be able to see how they do it.

ankit-m commented 8 years ago

@Ceilican, till then what should I do about the other fixes in this PR? Should I raise another with those changes?

ceilican commented 8 years ago

That would be ideal. But if it is too much work to do that, it is ok to wait for those fixes too, because they do not seem to be critically urgent. It is up to you.