Oiha-dev / MineMath

MineMath - Your Mathematical GUI Companion in Minecraft
Other
4 stars 0 forks source link

[Localization] Hardcoded Strings and too big Error Messages. #4

Open Amirhan-Taipovjan-Greatest-I opened 4 months ago

Amirhan-Taipovjan-Greatest-I commented 4 months ago

Hello!

I was searching for a good Minecraft Calculator Widget and found You. I also was researching Your Mod for translating it... and I found some Details that I think it nice to fix.

Factorial Float Error This message You can see in StrToMathExpression.java

Other Messages can't be found in Your Mod Code... It would be nice to make that Error Messages fitting in the Input Field and make them translatable.

Thank You for the Answer in Advance!

Oiha-dev commented 4 months ago

Hey, thanks for using my mod, I see the problem you're having, at the time I was using a lot of ChatGPT because it was my first mod and that didn't go well, I was thinking or remaking the code from scratch because I knew some bugs and strings hard coded. I will look at it this week and for the other error message I suspect they come from the library I'm using, I will try to make the update without or at least block them and make a place to display the error, not in the input field. If you found any other issue, tell me about them

Amirhan-Taipovjan-Greatest-I commented 4 months ago

Hey, thanks for using my mod, I see the problem you're having, at the time I was using a lot of ChatGPT because it was my first mod and that didn't go well, I was thinking or remaking the code from scratch because I knew some bugs and strings hard coded. I will look at it this week and for the other error message I suspect they come from the library I'm using, I will try to make the update without or at least block them and make a place to display the error, not in the input field. If you found any other issue, tell me about them

Those Error Messages that I was talking about... they also appear in the Calculation History:

image

Oiha-dev commented 4 months ago

Those Error Messages that I was talking about... they also appear in the Calculation History

Wow, ok thanks for letting me know

Oiha-dev commented 4 months ago

The library I'm using for the gui as updated for 1.20.6, so I will start working on the update