search

Oitzu / pimatic-location

4 stars 7 forks source link

GMaps API language (Streetnames) #33

Open nvirm opened 9 years ago

nvirm commented 9 years ago

Hello! The plugin seems to work flawlessly in general. However, some of the streetnames are being shown on my country's second language, some are shown right. Could it be possible to update the .APK to include language choosing (fi-FI, en-EN etc.) :+1: ?

Oitzu commented 9 years ago

Hi! The street-names are actually gathered by the plugin itself with the use of the google maps api. Are the streetnames you are talking about displayed correctly on google maps? I don't know if and how google maps supports multiple languages on streetnames.

nvirm commented 9 years ago

Sorry for the responsetiming! I have tried to fix the issue by myself (hobbying :)..), but with little results.

Unlike I first thought, the address resolving comes from the pimatic plugin, not the Android APK, I think..?

Links: https://developers.google.com/maps/faq?utm_source=welovemapsdevelopers&utm_campaign=mdr-launch#languagesupport https://developers.google.com/maps/documentation/geocoding/intro#Results

Optional parameters in a geocoding request: language — The language in which to return results. See the list of supported domain languages. Note that we often update supported languages so this list may not be exhaustive. If language is not supplied, the geocoder will attempt to use the native language of the domain from which the request is sent wherever possible.

The issue for me (I suppose any two-language countries have the same issue) is that the streetnames are chosen (seemingly) randomly from the two available languages.

if this gets resolved, perhaps adding a "language": "en-GB" part to config wouldn't hurt I suppose? the user could then easily select the language for himself from https://developers.google.com/maps/faq#languagesupport

nvirm commented 9 years ago

https://www.npmjs.com/package/googlemapsutil Is the library referenced in the plugin I suppose.

There seem to be mentions of language in the files, but so far I haven't been able to patch it to being functional in the plugin. :(

nvirm commented 9 years ago

Fixed by adding + "&language=fi" to googlemapsutil js file. :) .. However if it were a variable in config, it would be more user accessible.

Oitzu commented 9 years ago

Do you maybe feel safe enough to do pull request on corresponding repositories? The googlemapsutil.js is in this repository: https://github.com/Oitzu/googleMapsUtil The pimatic plugin is here: https://github.com/Oitzu/pimatic-location-plugin