OkCupid / sfslite

SFSlite C++ development libraries
GNU General Public License v2.0
55 stars 65 forks source link

crypt/pm.C does not compile #1

Closed theotherjimmy closed 11 years ago

theotherjimmy commented 12 years ago

Gcc is invovked with -Werror and -Wall through libtool, resulting in four errors exactly like: pm.C:72:57: error: narrowing conversion of '255' from 'int' to 'const char' inside { } is ill-formed in C++11 [-Werror=narrowing] to remedy this, cast all of the 0xFF's in line 72 of crypt/pm.C to chars: static const char match[4] = { (char) 0xFF, (char) 0xFF, (char) 0xFF, (char) 0xFF}; If you'd like, I can put up a PKGBUILD in the AUR shortly afer you post the fix. thanks, Jimmy

tomquisel commented 12 years ago

Thanks. I just tossed in a fix!

Let me know if you notice anything else.

Best, Tom

On Sun, Oct 7, 2012 at 12:52 AM, theotherjimmy notifications@github.comwrote:

Gcc is invovked with -Werror and -Wall through libtool, resulting in four errors exactly like: pm.C:72:57: error: narrowing conversion of '255' from 'int' to 'const char' inside { } is ill-formed in C++11 [-Werror=narrowing] to remedy this, cast all of the 0xFF's in line 72 of crypt/pm.C to chars: static const char match[4] = { (char) 0xFF, (char) 0xFF, (char) 0xFF, (char) 0xFF}; If you'd like, I can put up a PKGBUILD in the AUR shortly afer you post the fix. thanks, Jimmy

— Reply to this email directly or view it on GitHubhttps://github.com/okws/sfslite/issues/1.