search

OkCupid / sfslite

SFSlite C++ development libraries
GNU General Public License v2.0
55 stars 65 forks source link

Fix Tame line numbers off by one #5

Closed s4y closed 10 years ago

s4y commented 10 years ago

Line numbers in tamed code (in gdb) have been off by one for me for a while. I don't know this code super well, but this change fixes the cases I saw.

s4y commented 10 years ago

@till-varoquaux could you sanity check this change out when you have a chance?

till-varoquaux commented 10 years ago

Sidney's change makes sense to me, but I haven't checked that it actually works. I would probably re-output the line number marker instead of swallowing a line return, but that's a matter of taste. I say: apply that patch.

On Wed, Jan 29, 2014 at 12:33 PM, Sidney San Martín < notifications@github.com> wrote:

@till-varoquaux https://github.com/till-varoquaux could you sanity check this change out when you have a chance?

— Reply to this email directly or view it on GitHubhttps://github.com/okws/sfslite/pull/5#issuecomment-33608456 .

s4y commented 10 years ago

@till-varoquaux @mmaxim I just updated the patch to do that, should be good to go.