Okazari / Rythm.js

A javascript library that makes your page dance.
https://okazari.github.io/Rythm.js/
GNU General Public License v3.0
3.93k stars 252 forks source link

Update package-lock.json for node v10 #96

Closed third774 closed 5 years ago

third774 commented 6 years ago

Upgrade gulp for node v10

I was getting the following error after pulling down the repo and running npm i && npm start

npm i && npm start

> husky@0.14.3 install /Users/kevin/repos/Rythm.js/node_modules/husky
> node ./bin/install.js

husky
setting up Git hooks
done

npm WARN prepublish-on-install As of npm@5, `prepublish` scripts are deprecated.
npm WARN prepublish-on-install Use `prepare` for build steps and `prepublishOnly` for upload-only.
npm WARN prepublish-on-install See the deprecation note in `npm help scripts` for more information.

> rythm.js@2.2.4 prepublish /Users/kevin/repos/Rythm.js
> npm run build

> rythm.js@2.2.4 build /Users/kevin/repos/Rythm.js
> node build.js

added 595 packages from 341 contributors and audited 3686 packages in 15.107s
found 262 vulnerabilities (255 low, 1 moderate, 5 high, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

> rythm.js@2.2.4 start /Users/kevin/repos/Rythm.js
> concurrently --kill-others  "npm run serve" "npm run build -- -w"

[0]
[0] > rythm.js@2.2.4 serve /Users/kevin/repos/Rythm.js
[0] > gulp serve
[0]
[1]
[1] > rythm.js@2.2.4 build /Users/kevin/repos/Rythm.js
[1] > node build.js "-w"
[1]
[0] gulp[53272]: ../src/node_contextify.cc:628:static void node::contextify::ContextifyScript::New(const FunctionCallbackInfo<v8::Value> &): Assertion `args[1]->IsString()' failed.
[0]  1: 0x10003a08d node::Abort() [/usr/local/bin/node]
[0]  2: 0x1000390eb node::AddEnvironmentCleanupHook(v8::Isolate*, void (*)(void*), void*) [/usr/local/bin/node]
[0]  3: 0x1000637bb node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [/usr/local/bin/node]
[0]  4: 0x10025ac6f v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo*) [/usr/local/bin/node]
[0]  5: 0x100259e0b v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<true>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/usr/local/bin/node]
[0]  6: 0x100259827 v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/usr/local/bin/node]
[0]  7: 0xad1920dc01d
[0]  8: 0xad19208d145
[0]  9: 0xad19210b900
[0] 10: 0xad1920918b5
[0] 11: 0xad1920918b5
[0] 12: 0xad1920918b5
[0] npm run serve exited with code null
--> Sending SIGTERM to other processes..
[1] npm run build -- -w exited with code null
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! rythm.js@2.2.4 start: `concurrently --kill-others  "npm run serve" "npm run build -- -w"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the rythm.js@2.2.4 start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/kevin/.npm/_logs/2018-10-11T03_34_23_957Z-debug.log

After running npm i gulp@latest to upgrade the package, I was able to build and run the project successfully.

Okazari commented 6 years ago

Thanks for the contribution, i'll check that in the incomings days :)

Okazari commented 6 years ago

Hey. Sorry for the delay. I've been really busy theses days. Gonna give it a look asap to merge it before the end of the month

Okazari commented 5 years ago

Hey ! unfortunatly i decided to get rid of gulp as it is too old. I am now using watch-http-server Thanks anyway for your contribution !