Remove LOWER for pgsql driver because it's redundant

Okipa / laravel-table

Generate tables from Eloquent models.

MIT License

527 stars 64 forks source link

Remove LOWER for pgsql driver because it's redundant #151

Open HawtDogFlvrWtr opened 9 months ago

HawtDogFlvrWtr commented 9 months ago

Because you're forcing ILIKE when using the pgsql driver, you only need to cast to text and not lower. Lowering clobbers all indexes, making it impossible to improve query speeds. The below ILIKE when using pgsql takes care of lower and upper searches while still leaving the cast above for dates etc.

Okipa commented 8 months ago

Thanks for you PR, could you please pull the master and fix failing tests?