search

Okipa / laravel-table

Generate tables from Eloquent models.
MIT License
527 stars 64 forks source link

Migration difficulties with routes, #93

Closed Iaotle closed 1 year ago

Iaotle commented 1 year ago

Hi!

We've been using laravel-tables for our project, and the upgrade to v5 seems to require significant migration, specifically in the routes department. Whereas before you could specify routes using a routes variable, now you have to create actions and pass routes to them.

Could there be a backwards-compatible option in order to reduce the migration difficulties?

Also, it seems like the row actions aren't rendering properly and the icons are missing.

image

Okipa commented 1 year ago

Hi @Iaotle, I'm currently working on the upgrade guide in order to make the migration as smooth as possible but it will indeed demand a bit of work.

Regarding icons, this is because Fontawesome 6 is used by default, instead of Fontawesome 5.

I'll take account about your comment to add a part about routing in the migration guide.

I let you know when it is finished!

Okipa commented 1 year ago

Hi @Iaotle, I just finished the upgrade guide : https://github.com/Okipa/laravel-table/blob/v5/docs/upgrade-guides/from-v4-to-v5.md

Could you please follow it and tell me if everything is going well ?

This upgrade is a massive one and it is impossible to assure a backward compatibility with the routes method as actions are some new features based on Livewire and not based on a page-reloading behavior.