Code Checklist - Githubissues

OkraFramework / Okra.Core

Okra App Framework - The Okra App Framework is designed to support the development of .Net Windows Store applications, in particular those following the MVVM pattern.

http://okraframework.github.io

Apache License 2.0

10 stars 6 forks source link

Code Checklist #30

Closed Andy-Wilkinson closed 9 years ago

Andy-Wilkinson commented 10 years ago

~~Make sure there are no project warnings~~
~~Ensure that ‘Code Analysis’ is enabled~~
~~Validate all arguments~~
- ~~Null checks~~
- ~~Range checks~~
~~Ensure all unmanaged resources are disposed correctly~~
~~Ensure correct exception handling where likely calls to framework methods will fail~~
~~Remove any unreachable code~~
~~Override ToString(…) for any classes that might be useful (e.g. for debugging)~~
~~Check for memory leaks~~

Andy-Wilkinson commented 10 years ago

Enabled 'Code Analysis' for all assemblies

Andy-Wilkinson commented 10 years ago

All project build warnings have been fixed (apart from warnings about obsolete types which will all be removed in v1.0 when obsolete types have been removed)

Andy-Wilkinson commented 9 years ago

All arguments are now validated correctly

Andy-Wilkinson commented 9 years ago

Added ToString() for PageInfo to improve debugging experience

Andy-Wilkinson commented 9 years ago

Scanned code manually for other issues. Complete.