Open cruftex opened 1 year ago
Hi @cruftex,
Yes core is implementing webp and avif support but only for images generated via prestashop core and via php gd extension. In is_themecore mode we can chose driver for webp (best results you can achieve with imagick) and we are able to generate webp format for every jpg/png/jpeg image on store including every module and /img/cms. I am planning to create services and drivers for avif format also but it might take some time.
Before version 3.0.0 theme was named modern prestashop starter theme
and it's looks like I forgot to check documentation and adjust it to new rebranded theme name.
The README references version 8.0.0.X. It must be: 8.0.x
That's just another typo right there.
Fell free to create a PR. We should only use name 'falcon' to stay consistent and don't create confusion for docs readers.
Hi @Oksydan
Did you do already some testing with 8.1.x? We would like to update to 8.1.x soon, since bug fixes seem to go there.
Hi @cruftex,
I didn't test it yet. I will be test it when 3.1.0 version of falcon will be released. TBH I don't see much of a changes in version 8.1 that might harm falcon theme.
Summary
Below is actually four different things, but all regarding compatibility.
How about compatibility to PrestaShop 8.1.x?
How does webp support interact with the settings of PS 8.0 and the upcoming PS 8.1.
The image settings config screen in 8.0.1 looks like:
In the 8.1 release announcement, it is written:
Source: https://build.prestashop-project.org/news/2023/prestashop-8-1-beta-release/
How is the image compression in the theme aligned with the development in main PrestaShop?
I was checking the README and have some remarks:
The README references version 8.0.0.X. It must be: 8.0.x
The README speaks about a starter and a starter theme. E.g.:
This is confusing. I assume that starter and starter theme both means actually the falcon theme? If so, I suggest to changing it and use falcon theme consistently, or, just say "the theme". I am happy to read thoroughly and do a PR.
Feature target required module/theme
all
Drawbacks
no idea