search

Oksydan / falcon

Prestashop starter theme that provides great development experience.
GNU General Public License v3.0
263 stars 63 forks source link

🐛 [BUG] - Image slider module defined parameters should be unique #279

Closed Oksydan closed 1 year ago

Oksydan commented 1 year ago

Description

Parameters defined in is_imageslider commons.yml file module should contains unique name related to this module to prevent collision with other similar parameters.

Node.js version

N/A

php version

8.1

OS and it's version

MacOs

Browsers

Firefox, Chrome, Safari, Microsoft Edge, Opera

Required module/theme

is_imageslider

Reproduction steps

1. Create new module with the same parameter defined inside.
2. Try to use it inside module. You should see that this parameter is right now provided from is_imageslider module instead of your new module.

Logs

No response

Oksydan commented 1 year ago

New version has been released fixed via https://github.com/Oksydan/is_imageslider/pull/41