search

Oksydan / falcon

Prestashop starter theme that provides great development experience.
GNU General Public License v3.0
263 stars 63 forks source link

🐛 [BUG] - missing aria-label to prev and next links of is_imageslider #312

Closed maofree closed 10 months ago

maofree commented 1 year ago

Description

Hi google page speed alert me about an accessiblity problem about a text associated with the links of prev and next of is_imageslider module

normally to fix this type of error I use aria-label="Previous" and aria-label="Next"

1

Node.js version

v16

php version

8.1

OS and it's version

linux

Browsers

Chrome

Required module/theme

is_imageslider

Reproduction steps

1. look at the image or try a test with google page speed

Logs

No response

Oksydan commented 1 year ago

Hi @maofree,

thank you for creating an issue. It's more like improvements instead of bug. I am going to fix it in next version of is_imageslider module.

Oksydan commented 10 months ago

Hi @maofree

this problem has been fixed here https://github.com/Oksydan/is_imageslider/pull/50. It will be available in next major version. Thank you for your contribution.