Oksydan / falcon

Prestashop starter theme that provides great development experience.
GNU General Public License v3.0
263 stars 63 forks source link

🐛 [BUG] - [FIX] Wrong ARIA ROLE in the product tab list #325

Closed maofree closed 1 year ago

maofree commented 1 year ago

Description

Hi I've found and fixed this error

https://github.com/PrestaShop/PrestaShop/issues/34504

the role="tab" should be moved from the a tag to the li tag

like so in the product-tabs.tpl

Oksydan commented 1 year ago

Hi @maofree,

thank you for creating an issue. I am not sure yet is it valid solution 🤔 according to bootstrap it should be:

<ul class="nav nav-tabs" id="myTab" role="tablist">
  <li class="nav-item" role="presentation">
    <button class="nav-link active" id="home-tab" data-bs-toggle="tab" data-bs-target="#home" type="button" role="tab" aria-controls="home" aria-selected="true">Home</button>
  </li>
</ul>

I did small fixed on develop branch https://github.com/Oksydan/falcon/pull/328 - and product page now passes 100% lighthouse accessibility check.

I am closing this one. Thank you for once again.

maofree commented 1 year ago

Hi today I confirm that solution is good. I'm using it on the real website and I've tested it