Oksydan / falcon

Prestashop starter theme that provides great development experience.
GNU General Public License v3.0
263 stars 63 forks source link

🐛 [BUG] - [FIX] promo code click doesn't work, wrong class to the link #326

Closed maofree closed 1 year ago

maofree commented 1 year ago

Description

Hi it is necessary to replace "js-code" to "code" in this line like so <a href="#" class="code font-weight-bold">{$discount.code}</a> - {$discount.name}

if not the click on the promo code doesn't copy the code on the cart summary

1 2

bye

Node.js version

v16

php version

8.1

OS and it's version

linux

Browsers

Chrome

Required module/theme

theme

Reproduction steps

1. edit the cart-voucher.tpl
2. replace js-code to code

Logs

No response

yoan-webpremiere commented 1 year ago

Hello,

I think the best thing would be to leave the js-code class in cart-voucher.tpl and just change the name of the JS selector in "falcon/_dev/js/theme/components/selectors.js" (line.58) : discountCode: '.js-discount .code', to discountCode: '.js-discount .js-code',

Oksydan commented 1 year ago

Hi,

Thank you for your feedback. This problem has been fixed in version 4.0.0 on develop brach we can close this issue.