search

Oksydan / falcon

Prestashop starter theme that provides great development experience.
GNU General Public License v3.0
263 stars 63 forks source link

🐛 [BUG] - [FIX] is_imageslider wrong use of the legend field, it should be used for the alt_text #347

Closed maofree closed 10 months ago

maofree commented 1 year ago

Description

Hi I've seen that is_imageslider doesn't use the legend field in slider.tpl for the alt_text is used slide.title, but should be slide.legend

1

you could use a condition, where if the legend is not set then use the title, as happens for the alt_text of product images

bye

Node.js version

v16

php version

8.1

OS and it's version

linux

Browsers

Chrome

Required module/theme

is_imageslider

Reproduction steps

1. look at the file slider.tpl

Logs

No response

Oksydan commented 1 year ago

Hi @maofree,

thank you for creating an issue. I am adding it to is_imageslider epic for new version.

Oksydan commented 10 months ago

Hi @maofree,

this issue has been fixed here https://github.com/Oksydan/is_imageslider/pull/49 and it will be available in the next major version. Thank you for your contribution.