Oksydan / falcon

Prestashop starter theme that provides great development experience.
GNU General Public License v3.0
257 stars 61 forks source link

🐛 [BUG] - is_imageslider has a problem with slide pagination #423

Open maofree opened 1 month ago

maofree commented 1 month ago

Description

Hi when there are more than 10 slides in the slide list, pages of 10 slides per page are created. If I select 20 slides per page, then the slides are no longer displayed in the list, so the list becomes empty. This is useful for changing the position of the slides, you can only do it on one page

bye

Node.js version

v18

php version

8.1

OS and it's version

linux

Browsers

Chrome

Required module/theme

is_imageslider 2.3.2

Reproduction steps

1. Go to is_imageslider
2. add 12 slides
3. change the pagination to see 20 slides for each page
4. no slide is shown in the list

Logs

No response

Oksydan commented 1 month ago

Hi @maofree

Actually I am aware of this problem. It has been fixed on the branch with module refacto https://github.com/Oksydan/is_imageslider/blob/module-refacto/views/templates/admin/index.html.twig#L44 for now you can apply this fix. I am going to release patch version soon.

maofree commented 1 month ago

ok thanks