Okty-io / okty-config

Configuration repository of the simplest application to create docker projects
https://github.com/Okty-io/okty
GNU General Public License v3.0
13 stars 11 forks source link

[ADD] NodeJS container configuration #44

Closed kmarques closed 6 years ago

kmarques commented 6 years ago

Description

These pull request adds a new NodeJS configuration

Fixes nothing

Type of change

Which area/features are impacted ?

I have added a new container configuration to include NodeJS.

How can we manually test it ?

  1. Create an empty project
  2. Add a NodeJs container
  3. Configure it
  4. Export the project and unzip it
  5. Create a NodeJS project which serve the port 3000
  6. Execute docker-compose up -d

Checklist:

lbassin commented 6 years ago

Hi @kmarques ! Thanks for your contribution :smile: Sorry for the delay, I was on vacation

I'll test this container and accept your PR in next few days :+1:

lbassin commented 6 years ago

Thank you so much for this container !

I had to fix a small issue on the application about the command entry, there was an error when using "&&" https://github.com/Okty-io/okty/pull/136/commits/d8bcb268d31d2536afa0a7197a2c3ffc126f45d6

FYI we just added a new repository (https://github.com/Okty-io/docker-environment) which contains everything that is needed to run the application locally This allow us to add new container much easily