Okty-io / okty-config

Configuration repository of the simplest application to create docker projects

https://github.com/Okty-io/okty

GNU General Public License v3.0

13 stars 11 forks source link

Rename php to php-fpm #87

Closed Mapsred closed 5 years ago

Mapsred commented 5 years ago

Description

The current php container is in fact php-fpm, so to avoid misleading information, I renamed it to php-fpm

Before merging this issue, please take a look a this PR as is may break something if it is not merged first : https://github.com/Okty-io/okty-server/pull/25

Fixes # (issue)

No issue, but it will not have any visible change, it will only change the php to php-fpm in the container list

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds a functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Which area/features are impacted ?

the containers, the templates (because of php container dependency)

How can we manually test it ?

Create a docker-compose from a template and then from the php-fpm container

Checklist:

[ ] I have performed a self-review of my own code