search

OkunaOrg / okuna-web

🌈 Okuna for the web.
https://okuna.io
MIT License
67 stars 25 forks source link

Are variables for scss possible with vue and should they be used for max-width concerning screen width? #57

Open duichwer opened 4 years ago

duichwer commented 4 years ago

I don't know if it's possible to use a main variable scss file, but after i stumbled over some css rules like https://github.com/OkunaOrg/okuna-web/blob/46a25b158b638838f930d263099362705f956c9e/pages/home/pages/community/components/desktop-community-profile/OkDesktopCommunityProfile.vue#L29 https://github.com/OkunaOrg/okuna-web/blob/46a25b158b638838f930d263099362705f956c9e/pages/home/pages/user/components/desktop-user-profile/OkDesktopUserProfilePage.vue#L28

I asked myself if this value should come from a shared variable. Or maybe they should use the same class since the use the exact same values. I can understand that there can be reasons to use different classes, but if you change one of these values in the future you might wanna change the other one, too.

jozsefsallai commented 4 years ago

I don't know if it's possible to use a main variable scss file

It is possible and we will take your suggestion into consideration. Thank you! 🙂