search

Okuyun / Kuran

https://okuyun.github.io/Kuran/
6 stars 3 forks source link

Vertical swipe #2

Closed maeyler closed 3 years ago

maeyler commented 3 years ago

Vertical swipe should change current page Horizontal swipe should change current panel

maeyler commented 3 years ago

First implementation:

swipe right -- toggleTrans() // T button
swipe left -- toogleFinder() //pink button
swipe down -- prevPage() //down key
swipe up -- nextPage() //up key

Full animation is missing

maeyler commented 3 years ago

I am not sure if my up-down implementation is correct: UP key (keyboard), UP button (mouse & touch), UP swipe (touch) all behave the same way: nextPage

Is this really intuitive? UP key default is prevPage-- I modified the default behavior

Özetle şunu soruyorum: Up tuşu ve butonu alıştığımız gibi önceki sayfa mı? Yoksa Yukarı kaydırma gibi sonraki sayfa mı olsun?

maeyler commented 3 years ago

This issue is related to natural scrolling: https://www.huibdijkstra.nl/back-to-the-future-inverted-scrolling-for-windows https://www.lifewire.com/how-to-change-scrolling-direction-on-mac-2260835

gulcu commented 3 years ago

The default for UP key (prevPage) is what I expect, but the choices for left-right keys complicate matters in my opinion. Next Page for PDF Readers (for a left-to-right alphabet): Desktop- DOWN Key , Phone- Swipe UP My expected 'next page' from Mushaf in Iqra is to proceed to the next page when the LEFT key is pressed, since LEFT is forward in Arabic. Since the reverse is implemented, I think either all (current situation) or none (my personal preference) should be reversed.

maeyler commented 3 years ago

Vertical swipe should change current page Horizontal swipe should change current panel

Current version 4.1b seems to satisfy both goals

maeyler commented 3 years ago

UP swipe (touch): nextPage

Back to standard behavoir for keys: UP key (keyboard): prevPage LEFT button (mouse & touch): prevPage No need for UP button

maeyler commented 3 years ago

Horizontal swipe is finally implemented in all search panels

It works intuitively: Left and Right swipe cancel each other 3xLeft and 3xRight end up in the starting state