search

Olafski / FastLeafDecay

Minecraft mod that provides faster leaf decay.
21 stars 6 forks source link

[1.12.1] Fast Leaf Decay loaded a new chunk #12

Closed ProsperCraft closed 6 years ago

ProsperCraft commented 7 years ago

Is this reportable?

[21:54:28] [Server thread/WARN] [FML]: Fast Leaf Decay loaded a new chunk (-94, 148 Dimension: -50) during chunk population, causing cascading worldgen lag. Please report this to the mod's issue tracker. This log can be disabled in the Forge config. [21:54:28] [Server thread/WARN] [FML]: Fast Leaf Decay loaded a new chunk (-93, 146 Dimension: -50) during chunk population, causing cascading worldgen lag. Please report this to the mod's issue tracker. This log can be disabled in the Forge config. [21:54:28] [Server thread/WARN]: Couldn't set data of loot item 2xitem.spaceship@0 [21:54:28] [Server thread/WARN] [FML]: Fast Leaf Decay loaded a new chunk (-95, 159 Dimension: -50) during chunk population, causing cascading worldgen lag. Please report this to the mod's issue tracker. This log can be disabled in the Forge config.

Olafski commented 7 years ago

Could this be related to https://github.com/Olafski/FastLeafDecay/issues/8? That issue was closed by the person who reported it, because it turned out the issue was with another mod.

asphaltbuffet commented 6 years ago

I'm getting the same error log report but not running forestry.

XDGFX commented 6 years ago

I've got the same issue, also not running forestry

generrosity commented 6 years ago

Similar when doing massive worldgen.

Occasionally I get a Quark warning with it too, but AFAIK it doesn't touch trees.

I can only assume that FastLeafDecay is checking for a leaf block over the edge to see if it should expire? That would only occur if a mod isn't using fairly standard methods to keep trees from spawning at chunk edges until the neighboring chunk has been created.

While its possible there might be an Excpetion to catch to discover what mod is generating bad leaf placement, it could also be legit (such as Thaumcraft trees being fairly epicly big) and not too much of a problem unless the cascade keeps cascading?

Olafski commented 6 years ago

I don't know what to tell you.. I have seen this in my logs as well, but it never caused an issue for me.

The way this mod removes leaves is by triggering a block update whenever an adjacent block is updated. If it loads new chunks, that means a block on the very edge of the "loaded world" is updated. In that case, it will attempt to trigger a block update on the block that is in an unloaded chunk. This should happen only a finite amount of times.

I could add a check whether a chunk is loaded before queueing the block update, but that would probably just make regular operation a lot slower.