Olafski / FastLeafDecay

Minecraft mod that provides faster leaf decay.
20 stars 6 forks source link

FastLeafDecay hard crash with The Abyss Chapter II #46

Closed iobiarg closed 3 years ago

iobiarg commented 3 years ago

Getting a crash each time i break any vegetable (like grass)... latest.log

Already happened 3 times, already reported to The Abyss Devs.

Y3Z0N commented 3 years ago

Note from the Dev (AbyssCp2) (ME)

"Fast Leaf Decay tries to find a persistent value in the Blueberry Leaves block but it doesn't have one. Game crashes when loading dimension."

your mod "fastleafdecay" checks for values that don't even exists. abyss don't use the leaf decay feature. you should probably add a way to check if the existing block uses leaf decay inside the Minecraft:leaves tag. there are some other mods who don't use leave decay and there's the same situation (checked 5 mins ago) result = gatecrash caused by fastleafdecay.

//Edit

that's the important part:

[16feb2021 02:27:01.055] [Server thread/ERROR] [net.minecraftforge.eventbus.EventBus/EVENTBUS]: Exception caught during firing event: Cannot get property BooleanProperty {name=persistent, clazz=class java.lang.Boolean, values=[true, false]} as it does not exist in Block{theabyss:abyssleaves}

Olafski commented 3 years ago

Which version of FastLeafDecay are you using? I don't see the mod name mentioned anywhere in your log.

My mod (at least recent versions) checks if a block inherits from LeavesBlock. As far as I know, it does nothing with persistent values or anything like that. If other mods create blocks that inherit from leaves but somehow aren't leaves, I'm not sure what to do with that. (and I literally mean I don't know, I can barely get this mod to compile with every new version ;))

TelepathicGrunt commented 3 years ago

Actually the best practice would be instead of doing .get( to get a property of a block right away, it’s always wise to do a .hasProperty( check beforehand. There’s always gonna be edge case blocks you will come across so always check that it has the property first before obtaining it

you did say you aren’t doing anything with persistent properties which is interesting. I can take a look later to find how exactly the conflict is occurring. Give me a moment lol

TelepathicGrunt commented 3 years ago

@iobiarg @Y3Z0N you two got the wrong mod lmao It's Rapid Leaf Decay that is crashing. Not Fast Leaf Decay lol @iobiarg You can close these issue reports. I'll go poke the actual mod in question

Y3Z0N commented 3 years ago

from my side out #closed Because of reporting to the wrong mod. Im sorry sadly i thought this was the github for RapidLeafDecay. names confused me.

Olafski commented 3 years ago

Well, that clears up a lot of confusion! Thanks for the followup people. :)

And I can imagine the names are confusing. There are 3 mods with synonymous names that all do just about the same thing... :)