OlafvdSpek / xbt

High-Performance BitTorrent Tracker
GNU General Public License v3.0
178 stars 69 forks source link

The program uses the deprecated torrent_pass instead of torrent_pass_version. #120

Open AngelOfFear opened 6 months ago

AngelOfFear commented 6 months ago

The program uses the deprecated torrent_pass instead of torrent_pass_version.

In documentation https://visigod.com/xbt-tracker/table-documentation I see torrent_pass - A unique identifier for the user. Each torrent that the user downloads will have the torrent_pass in the announce URL. The user will have the same torrent_pass in every torrent he/she downloads. This is deprecated and replaced by the torrent_pass_version. Optional field.

torrent_pass_version - The new unique identifier for the user. Each time a user downloads a torrent a new key is generated and added to the tracker announce URL (in the torrent). This value is also increased. This way each torrent will have it's own torrent_pass and can't be reused on other torrents.

But in xbt_tracker.sql I see torrent_pass char(32) not null, -- torrent_pass_version int not null default 0,

and in terminal I see Unknown column 'torrent_pass' in 'field list' select uid, torrent_pass, downloaded, uploaded from xbt_users where 0

because in my db i use torrent_pass_version.

Fix please!

OlafvdSpek commented 6 months ago

The field isn't optional (anymore).

AngelOfFear commented 6 months ago

The field isn't optional (anymore).

What is mean? XBT Tracker uses deprecated torrent_pass again? I can't use torrent_pass_version anymore?

OlafvdSpek commented 6 months ago

You can use both.

AngelOfFear commented 6 months ago

You can use both.

I.e. I should just add the missing torrent_pass char(32) not null field. And should I somehow specify in the settings that I need to use only torrent_pass_version?