search

OldHaven-Network / MegaMod-Mixins

MegaMod-Mixins. A mod for b1.7.3
https://www.oldhaven.net/megamod.html
GNU General Public License v3.0
6 stars 2 forks source link

Remove old MinecraftCapes endpoint #49

Closed james090500 closed 3 years ago

james090500 commented 3 years ago

This endpoint is dead and no longer used

https://github.com/OldHaven-Network/MegaMod-Mixins/blob/3361dcc3613a780445272e5f61772c482bfc8cde/src/main/java/net/oldhaven/customs/util/SkinFix.java#L93

james090500 commented 3 years ago

Also please use the new up to date base64 endpoints for capes, your current endpoint ignore our caching system and will cause issues for the end users

https://minecraftcapes.net/profile/ba4161c03a42496c8ae07d13372f3371

ScarletLovell commented 3 years ago

Oops, I'm not sure why that capesList array is still there, underneeth it is the actual URL. https://github.com/OldHaven-Network/MegaMod-Mixins/blob/3361dcc3613a780445272e5f61772c482bfc8cde/src/main/java/net/oldhaven/customs/util/SkinFix.java#L111 However, thank you for your issue. I have realized the problem and updating to the newest base64 endpoint. Ears use a similar system, so it shouldn't be too difficult to convert mccapes to it.

james090500 commented 3 years ago

Thanks, just a note is that animated capes are a feature so you may want to do some check on the received texture. Something like, if animatedCapes is true then you'll need to crop the image...

ScarletLovell commented 3 years ago

Fixed in https://github.com/OldHaven-Network/MegaMod-Mixins/commit/74df9639af789cac29afd77d36fbeeaeae7d1a37