Ole8700 / openhab

Automatically exported from code.google.com/p/openhab
GNU General Public License v3.0
1 stars 0 forks source link

GCal integration not working #222

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Configure GCal integration
2. Schedule calendar events.
3. nothing happens

What is the expected output? What do you see instead?
* Events should trigger action in openHAB.
* In debug mode, no messages appear, except for bundle activation.

What version of the product are you using? On what operating system?
1.2.0 - from repo

Please provide any additional information below.

I've looked through the code, and I believe there's a bug with the shutdown 
variable.

Code looks like this:
    public void activate() {
        try {
            scheduler = StdSchedulerFactory.getDefaultScheduler();
            start();
        }
        catch (SchedulerException se) {
            logger.error("initializing scheduler throws exception", se);
        }
}

This ignores the super.activate() which set shutdown variable to false.  Either 
shutdown should be set in the overridden method, or a call to super.activate() 
should be added (I think :)

Original issue reported on code.google.com by t...@ducbase.com on 29 Mar 2013 at 12:56

GoogleCodeExporter commented 9 years ago

Original comment by kai.openhab on 29 Mar 2013 at 12:57

GoogleCodeExporter commented 9 years ago
Tom, you are absolutely right. Tock the super.activate() option ;-)

Fixed with 
http://code.google.com/p/openhab/source/detail?r=1ca5f8c56a5d8722640cd14da047617
4442a7e61

Original comment by teichsta on 29 Mar 2013 at 3:31