search

OlegKi / jqGrid-plugins

some plugins or extensions to jqGrid
36 stars 15 forks source link

Font Awesome icons are not showed in inline actions #1

Closed johncze closed 9 years ago

johncze commented 9 years ago

untitled

OlegKi commented 9 years ago

Hi,

I updated jQuery.jqGrid.fontAwesome4.css and jQuery.jqGrid.fontAwesome4.js to support the icons of formatter: "actions". It should replace the icons too.

Best regards Oleg

johncze commented 9 years ago

Hi Oleg,

thank you for that what are you doing for jqGrid community. Icons are ok now, but their css styles (background and border) are not ok :( See screenshot.

untitled

Many thanks,

Daniel

OlegKi commented 9 years ago

You are welcome! Do you really use the current version of CSS? It contains the new lines which removes the background and the border.

Best regards Oleg

johncze commented 9 years ago

I'm sorry. It's ok. It was my failure, because browser had cached a old version.

Many thanks,

Daniel

OlegKi commented 9 years ago

You are welcome!

Best regards Oleg P.S. I recommend you take a look in https://github.com/OlegKi/jqGrid where I develop free version of jqGrid. I will publish new version soon. The version contains many bug fixes (to 4.7.0), improvements and some new features like new methods setColWidth and autoResizeColumn. I created the feature based on autoWidthColumns (see here and here), but the new implementation is much better from performance point of view. The method autoResizeColumn works together with new property autoResizable: true in colModel. It allows to set the width of the column based on the maximal width of content of the column (and the column headers). Additionally one can resize the width of the column to the optimal size by double-click on the column header (double-click between in header between the columns). The description of the features and the documentation will be created later. The following demos show the new feature: demo1 - uses default features with shrinkToFit: false demo2 - uses autoResizableCompact: true with shrinkToFit: false demo3 - it uses shrinking (default shrinkToFit: true) and autoResizableFixWidthOnShrink: true with autoResizableCompact: true demo4 - autoresizing of all columns on loading/sorting/paging demo5 - demonstrate the performance. It uses grid with 1000 rows.

Your suggestions are welcome.

johncze commented 9 years ago

Wow, it sounds very good and demos also are great :) I am using many plugins from you. I know that I would not solve it here, but I don't know how to solve it. Pls look at https://stackoverflow.com/questions/27704402/jqgrid-add-new-row-and-disable-restorerow-function

OlegKi commented 9 years ago

I posted my answer on your question on the stackoverflow.

johncze commented 9 years ago

I know that I still bother you, but I found I hope last a little bug with trash icon. If I will add new row, trash icon is still old from jquery ui. See screenshot.

untitled

OlegKi commented 9 years ago

Hi! I suppose you used addRow or addRowData to add new row. Please post small parts of code, the reference to the demo in the future.

I updated jQuery.jqGrid.fontAwesome4.js. It should work now.

Best regards Oleg

johncze commented 9 years ago

Hi, very thank you for fixed jQuery.jqGrid.fontAwesome4.js. I don't know which exactly part do you want. I am sorry that my code is in coffeescript, but I think coffeescript is great and easier to read than javascript. If you will be to need then I will post javascript built from coffeescript, but code will not be nice.

This is my whole file with Table

Deleted code

OlegKi commented 9 years ago

Sorry, but I don't understand whether the problem is fixed now or not. If the problem is fixed then I don't need to read code.

If the problem is fixed, please close the issue.

About CoffeeScript or TypeScript and other. I find the idea of the languages good, but I don't use the languages myself now. Reading of code in the language which one don't know good is dangerous. I mean that one can think the one understand the the code, but one can misunderstand it instead. JavaScript is the typical example of the language which looks like Java, C# or many other, but which works in another way. The time of life of variables in the functions, the scope of visibility and its existence, the concept or constructors, the meaning and the usage of this and so on. All these are different as in the most well known languages. After first errors in the area I am very cautious in reading on the code in the language which I don't really good know.

johncze commented 9 years ago

I'm sorry for my previous post, but I understood your previous post wrong. Now trash icon is ok though I will add new row.

Thank you very much and ignore my previous post, please.

Daniel

OlegKi commented 9 years ago

No problem. You are welcome!