OlegWock / anori

Customizable new tab extension for Chrome, Firefox and Safari
https://anori.app
GNU Affero General Public License v3.0
348 stars 46 forks source link

picture plugin #176

Closed slayernominee closed 7 months ago

slayernominee commented 7 months ago

addressing https://github.com/OlegWock/anori/issues/52

Bildschirmfoto 2024-04-03 um 21 22 51

the preview image (deer) is locally added.

the image can be set via an url setting

Bildschirmfoto 2024-04-03 um 21 44 05
slayernominee commented 7 months ago

the deer is btw from unsplash

slayernominee commented 7 months ago

i see one problem with not using a placeholder image: with no internet connection the mock will not have an image to show / shows the alt text respectively with a slow internet connection it shows nothing at first

possible solutions for this would be if we either use a placeholder image (or maybe even some random selected one from a multiple intern images) or some css animation ig

OlegWock commented 7 months ago

That's true, but I think it will be a rare occurrence. Anori is browser extension, so user probably will have internet connection while using it anyway. And even if they don't, picture widgets in folder won't work without internet anyway, so I don't think we need 'special treatment' for mock (which user will see a lot less often)

slayernominee commented 7 months ago

removed it

OlegWock commented 7 months ago

Thanks :)