search

OlexG / branham-chat

0 stars 1 forks source link

Add support for markdown and emoji (:smile:) #18

Closed Sptele closed 2 years ago

Sptele commented 2 years ago

This allows for the use of markdown and emojis (processed in the server). It is sanitized using DOMPurify, and has an error message if invalid things are sent (such as script tags). I know we are switching to Preact/React, so this will just be stored here for future use, since the use should be similar, just with React components.

Sptele commented 2 years ago

(Here's an emoji selection lib: https://emoji-button.js.org/)

mattfbacon commented 2 years ago

This is now wholly outdated. On the one hand, prioritizing this earlier would have prevented staleness. On the other, there are still unresolved questions, and the implementation now would look nothing like the implementation then.

Nevertheless, we've started using React to allow for more component-driven development in the main branch branch. The holdback is implementation: who will implement this new feature?

There's #10 , which if implemented, would let us say "well, make the assignee do it." But this isn't particularly satisfying. Namely, there is no assignee on the issue. So these are the course of action we have here:

  1. Make the original PR creator do it (you)
  2. Make the frontend developer most familiar with the new frontend do it (Oleks)
  3. Copy-paste frantically from Medium articles

I'm inclined to suggest we follow 1.

In any case, I'm closing out this particular PR as the implementation here has no path forward given the divergence upstream.

Sptele commented 2 years ago

I can do it!