search

Olf0 / sfos-upgrade

Upgrading SailfishOS fail-safe and semi-automated at the command line
https://openrepos.net/content/olf/sfos-upgrade
GNU Lesser General Public License v2.1
8 stars 4 forks source link

Unnecessary Stop Release enforced? [Bug] Unbound variable! #97

Closed nephros closed 1 year ago

nephros commented 1 year ago

SailfishOS VERSION : 2.0.0.10
HARDWARE : Jolla Tablet
sfos-upgrade VERSION: 3.9.17

QUESTION

Internal list of stop releases: Is sfos-upgrade more zealous than the Jolla list?

STEPS TO REPRODUCE

Running sfos-upgrade on 2.0.0.10, wanting to update to 2.2.0.29 will output:

Notice: Upgrading from 2.0.0.10 to 2.2.0.29 would omit installing 2.0.5.6 as a stop release!

Now, the d.s.o page on Releases sais this step, 2.0.0.10 -> 2.2.0.29 should be possible.

I don't mind sfos-update being more careful than the list prescribes, but I was curious whether there was maybe some outdated internal list in the tool, or an omission on Jolla's list.

ADDITIONAL INFORMATION

By the way, sfos-upgrade 3.9.17 is capable of performing its duty on SFOS 1.1.9.30 which was a bit surprising to me but kudos to you for making it so very portable.

And more by the way, actually sfos-upgrade does give an error when running it on such old releases, namely:

[root@Jolla nemo]# sfos-upgrade 2.2.0.29
/usr/bin/sfos-upgrade: line 205: sailfishdocs_sfos_releases: unbound variable
Warning: "2.2.0.29" does not seem to be a publicly released SailfishOS version!
Do you really want to continue? (y/N) y

I haven't investigated deeply but I assume it's simply because ancient ssl certificates on such old releases will make the curl call(s) fail. Harmless in my book so I'm ignoring that.

nephros commented 1 year ago

I don't mind sfos-update being more careful than the list prescribes, but I was curious whether there was maybe some outdated internal list in the tool, or an omission on Jolla's list.

Ah found your comment stating that 2.0.5.6 is an extra entry in the internal list.

I guess that answers this question.

Olf0 commented 1 year ago
nephros commented 1 year ago

Hope you have recovered well.

On the topic of "weird" stop releases, I believe 4.5.0.16 is not a stop release any more, but the script treats it as such.

Olf0 commented 1 year ago

Hope you have recovered well.

Dunno, as I am still in the process.

On the topic of "weird" stop releases, I believe 4.5.0.16 is not a stop release any more, but the script treats it as such.

@nephros, you are regressing :wink:: As always the point release number is irrelevant WRT stop releases, installing any point release of a stop release will do.

4.5.0.18 is in the devel branch for two weeks already, simply did not find the time to release it as part of v3.9.18.

Olf0 commented 1 year ago

Fixed by commit 0427d48, line 179. Will be released in v3.9.19.

Olf0 commented 1 year ago

On the topic of "weird" stop releases, I believe 4.5.0.16 is not a stop release any more, but the script treats it as such.

BTW, as so often Jolla misses to update their lists, e.g. docs.sailfishos.org/Support/Releases/README.md still displays 4.5.0.16 as latest stop release as of 2023-03-18, despite 4.5.0.18 was GA-released on 2023-02-16. Hence Jolla regularly tricks sfos-upgrade into using an older point release as a stop release, despite me having updated sfos-upgrade's internal list of stop releases in a timely manner (usually within days after a new point release of a stop release).

Consequently I had no choice, but to rework and complicate the way the stop releases are handled: Now they are stripped of their point release number and then matched against the highest point release of each SailfishOS version X.Y.Z. See PR #103 for details.