OlhenShu / GreenCityProjectStage

0 stars 0 forks source link

[Eco-News, GET/econews/isLikedByUser] The response code 400 (Bad request) is not documented in the response codes list #300

Open OlhenShu opened 11 months ago

OlhenShu commented 11 months ago

Environment: Windows 11 Home Chrome 114.0.5735.91 (Official buid) (64-bit) GreenCityDocker-3 is built and running.

Reproducible: always.

Pre-conditions: User is logged in.

Steps to reproduce:

  1. Select the “Eco-news" controller.
  2. Select the method GET/econews/isLikedByUser.
  3. Set some letters (e.g abc) as the "id" value and send the request.
  4. Compare the returned response code with the list of documented response codes.

Actual result: The 400 (Bad request) response code is not documented in the response codes list.

Expected result: The 400 (Bad request) response code is documented in the response codes list

OleksandrKobetsDev commented 11 months ago

Execution of paragraph 3. is impossible because the input specified "id" field only accepts integer values. When specifying an integer value that is not present in the database, code 404 is returned - resource not found. Thus, using status code 400 is not justified.