search

Oli8 / spaper

PaperCSS components for Svelte
https://oli8.github.io/spaper/
MIT License
198 stars 9 forks source link

Svelte 4 support? #87

Open homostellaris opened 3 months ago

homostellaris commented 3 months ago

Thanks for the library, I'm using it at https://scheduleyour.social and its working great 🙏

I'm going to try upgrading to Svelte 4 and check everything still works, my understanding is that most libraries won't be broken by upgrading to Svelte 4 but just wanna check if there are any known reasons why this definitely won't work before I invest too much time? And if any changes are required, will you accept a PR?

Oli8 commented 3 months ago

Thanks for the kind words and the PR, I'll try to check this out over the week-end

Oli8 commented 3 months ago

Tested the current version of spaper on a v4 Svelte (with rollup) app.

Those components are broken:

Those are affected:

homostellaris commented 3 months ago

Tested the current version of spaper on a v4 Svelte (with rollup) app.

Those components are broken:

  • Tabs
  • Carousel

Those are affected:

  • Collapsible
  • Slider
  • Pagination
  • Popover
  • Toast

Ah that's a shame. Are you intending to fix them? If you share your testing methodology I could help?

homostellaris commented 2 months ago

Just FYI I've been using this in earnest with Svelte 4 and I've not had any issues. My app only uses Popover and Toast though.

shiftlabs1 commented 1 week ago

@Oli8 , I think the ask should be plans to upgrade to svelte5 (or at least a branch version for svelte 5) using runes

Oli8 commented 1 week ago

@Oli8 , I think the ask should be plans to upgrade to svelte5 (or at least a branch version for svelte 5) using runes

Yep, agreed, I'll get to it eventually but can't know when, contributions are welcome