search

Oli8 / spaper

PaperCSS components for Svelte
https://oli8.github.io/spaper/
MIT License
199 stars 9 forks source link

Upgrade to svelte 4 #88

Open homostellaris opened 6 months ago

homostellaris commented 6 months ago

Raised a PR with the changes from running npx svelte-migrate@latest svelte-4 plus a couple of my own in package JSON (see commit messages for rationale on those).

I've no idea if this has broken anything but judging by the diff it looks very unlikely and this at least creates a branch to test - any suggestions on the best way to do this?

Obviously totally understand if this is not a priority but thought I could at least be as helpful as possible to try get this support in. If merged this would close #87.

Oli8 commented 6 months ago

Might be better/safer if I first upgrade sveltekit

homostellaris commented 6 months ago

Might be better/safer if I first upgrade sveltekit

Just out of interest why do you need SvelteKit? It's just a Svelte component library right? So it may be used without SvelteKit or with another framework.

Oli8 commented 6 months ago

Might be better/safer if I first upgrade sveltekit

Just out of interest why do you need SvelteKit? It's just a Svelte component library right? So it may be used without SvelteKit or with another framework.

Sveltekit provides a great way to write svelte library https://kit.svelte.dev/docs/packaging

Also note that currently the package.json of the repo is different from he final package.json of the packaged library, this changes in newer sveltekit version

homostellaris commented 6 months ago

Although it's on the SvelteKit website it looks like it's just @sveltejs/package you need not @sveltejs/kit 🙂

On Wed, 13 Mar 2024, 13:11 Olivier, @.***> wrote:

Might be better/safer if I first upgrade sveltekit

Just out of interest why do you need SvelteKit? It's just a Svelte component library right? So it may be used without SvelteKit or with another framework.

Sveltekit provides a great way to write svelte library https://kit.svelte.dev/docs/packaging

— Reply to this email directly, view it on GitHub https://github.com/Oli8/spaper/pull/88#issuecomment-1994374819, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADT4RV445VACY7R6OYPCSD3YYBGAZAVCNFSM6AAAAABEMV67Y2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJUGM3TIOBRHE . You are receiving this because you authored the thread.Message ID: @.***>

Oli8 commented 6 months ago

Although it's on the SvelteKit website it looks like it's just @sveltejs/package you need not @sveltejs/kit 🙂

Looks that way now but it was part of kit then