search

Olian04 / github-readme

A custom element that renders the readme of a github repository
https://olian04.github.io/github-readme/
MIT License
17 stars 3 forks source link

Make CSS backward compatible and format js #1

Closed Richienb closed 5 years ago

Olian04 commented 5 years ago

Thanks for the PR! Unfortunately it looks like your changes to the styles broke the indented behavior of buttons in the nav bar. Please fix this and I'll have another look. :smile:

Richienb commented 5 years ago

I fixed the code.

Olian04 commented 5 years ago

Awesome, I'll have a look at this tomorrow. Thank you!

Olian04 commented 5 years ago

Your latest commit broke the code.

Uncaught SyntaxError: Identifier 'backButton' has already been declared

Please make sure the code runs without errors, then ping me, and l'll have another look.

Richienb commented 5 years ago

I fixed the code!

Richienb commented 5 years ago

@Olian04 I fixed the code!

Olian04 commented 5 years ago

Great job. I'll have a look at it as soon as I have the time to spare :)

Olian04 commented 5 years ago

Looks good. Thank you!