search

Olical / aniseed

Neovim configuration and plugins in Fennel (Lisp compiled to Lua)
https://discord.gg/wXAMr8F
The Unlicense
610 stars 28 forks source link

Add antifennel support #140

Closed randomizedthinking closed 1 year ago

randomizedthinking commented 1 year ago

This is a slightly updated to add antifennel support in aniseed.

Olical commented 1 year ago

I've been busy with work and away on holiday for a while but I'll look at this ASAP. Ideally I'd remove the floating window code and just basically echo it to avoid any extra UI work in the Aniseed repo. Then when invoked from Conjure it could display a log window reusing all of the UI modules inside that repo to display the output nicely.

Sorry that I didn't make that clear in the first place, I don't want to start building a second tower of UI modules in Aniseed, I'd rather it stayed low level and headless with Conjure being the UI side of it. I'll have a look at this change soon and will built ontop of your PR.

Olical commented 1 year ago

I was going to change the target branch to develop but I see a duplicate commit d8a3107, so maybe something funky is going on with the history? Could you point this PR at the develop branch and make sure the commits are rebased on top of it? Thanks!

I still need to look over how the UI works because I still don't really want to introduce UI concepts to Aniseed, it's mostly headless with Conjure being the UI at the moment.

Thinking about it further, this may just be better suited to being a completely standalone plugin? Does it actually rely on any concepts / features of Aniseed? Isn't it a totally different thing with it's own config, UI and concerns? 🤔

randomizedthinking commented 1 year ago

Oh, recently I merged all the latest changes in Olical/aniseed to mine. It must be the cause of the funny things you saw. I can re-submit a PR in the develop branch.

Personally, I think this small addon is a natural part of aniseed: it helps fennel development especially for beginners. It is a part of the fennel support on emacs. Basically, I borrowed the idea from the fennel author.

On Fri, Aug 11, 2023 at 5:13 AM Oliver Caldwell @.***> wrote:

I was going to change the target branch to develop but I see a duplicate commit d8a3107 https://github.com/Olical/aniseed/commit/d8a3107d2cdb94b107e0c5f293bf6f8d38ddf3e8, so maybe something funky is going on with the history? Could you point this PR at the develop branch and make sure the commits are rebased on top of it? Thanks!

I still need to look over how the UI works because I still don't really want to introduce UI concepts to Aniseed, it's mostly headless with Conjure being the UI at the moment.

Thinking about it further, this may just be better suited to being a completely standalone plugin? Does it actually rely on any concepts / features of Aniseed? Isn't it a totally different thing with it's own config, UI and concerns? 🤔

— Reply to this email directly, view it on GitHub https://github.com/Olical/aniseed/pull/140#issuecomment-1674657267, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIJ4ZTJ4FQMAZNNQGQYWZLXUYOX5ANCNFSM6AAAAAAVDPC5OY . You are receiving this because you authored the thread.Message ID: @.***>

randomizedthinking commented 1 year ago

Close and re-submit to the develop branch.