Closed kkharji closed 3 years ago
Oh awesome! I didn't know about --headless
, that actually removes the need for my results.txt
entirely, I'll have a play with this later but I think I can delete some code around this so results.txt will never even get created.
I'm not so sure about removing test/lua
, I still think it's good to leave that there for debugging, it should just be in your .gitignore
.
And I feel like deps
in the default build were pretty handy since it ensures you're in sync with what's specified in the makefile, this is something I think I rely on in the CI but that could be changed. I quite liked that make
on it's own would do everything required to run the tests, there was no "if this then that" logic to running the makefile.
Open to being convinced otherwise though.
Oh awesome! I didn't know about
--headless
, that actually removes the need for myresults.txt
entirely, I'll have a play with this later but I think I can delete some code around this so results.txt will never even get created.
Yah me neither, just saw a lot of people starting to use as a script runner and usning --headless which is pretty cool.
I'm not so sure about removing
test/lua
, I still think it's good to leave that there for debugging, it should just be in your.gitignore
.
I agree, I forgot that I had it in gitignore.
And I feel like
deps
in the default build were pretty handy since it ensures you're in sync with what's specified in the makefile, this is something I think I rely on in the CI but that could be changed. I quite liked thatmake
on it's own would do everything required to run the tests, there was no "if this then that" logic to running the makefile.
Yah I love it how make is the source of truth for testing and getting the setup running flawlessly. I didn't quite the part about deps and CI
Merged! It looks good to me so far :) the only thing I went back on was the seed/Makefile
changes.
This helps with debugging parts of the makefile that fail, you'll know what was just run to produce that error. I tend to err on the side of noise so that people aren't left in the dark with issues, but users are more than welcome to tweak things to make them silent if they're confident in what's going on.
Thank you very much for the improvements! They're on develop for now, I'll give them a try out as I work on the next release then publish it all to master soon :)
Thanks @Olical , I’m going to use aniseed heavily next few weeks for my new lib so I will open pr to develop if I found interesting stuff that can be improved
MAKEFLAGS += --silent
to silent deleting and removing of filesOther: