search

Olical / aniseed

Neovim configuration and plugins in Fennel (Lisp compiled to Lua)
https://discord.gg/wXAMr8F
The Unlicense
606 stars 28 forks source link

Check plugin name in seed.sh #29

Closed sotte closed 3 years ago

sotte commented 3 years ago

Fail early when there are dots in the name of plugins when creating new plugins (with seed.sh).

Now you get the following error when a new plugin contains a .:

stefan@faultier:/t/foo.bar
➤ pwd
/tmp/foo.bar
stefan@faultier:/t/foo.bar
➤ ~/coding/aniseed/scripts/seed.sh
ERROR: Invalid plugin name 'foo.bar'. Dots (.) are not allowed.
stefan@faultier:/t/foo.bar

I also switched seed.sh from sh to bash, not sure if you used sh on purpose. All other scripts use bash.

Olical commented 3 years ago

Ohh thank you! I'll merge and publish this tomorrow, a really neat idea. I'm all for anything that adds a guard rail to protect users.

sotte commented 3 years ago

Thanks for merging and thanks for aniseed!

Olical commented 3 years ago

It's a neat addition, thanks for the PR! I'll tag it soon but I'm just waiting to see if my change to plugin/aniseed.vim is okay first, there's this bug that I'm trying to solve in Conjure and Aniseed, it seems like packer (I think) doesn't sync the runtimepath like all other plugin managers, which I rely on :grimacing:

https://github.com/Olical/conjure/issues/159