search

Olical / cljs-test-runner

Discover and run your ClojureScript tests
https://clojars.org/olical/cljs-test-runner
The Unlicense
85 stars 16 forks source link

Upgrade doo and add firefox support #41

Closed kongeor closed 7 months ago

kongeor commented 1 year ago

Hello,

thank you for your work on this.

I'm using this test runner without issues after having bumped doo's patch version. I've also added firefox support which can be convenient for cross browser testing. Latest versions of Chrome and FF are working fine at the moment with the karma test runner. Is it ok to create a PR with those two changes: https://github.com/Olical/cljs-test-runner/compare/master...kongeor:cljs-test-runner:master

Thanks!

Olical commented 1 year ago

That sounds great to me! Thank you.

On Sun, 20 Nov 2022, 20:29 Kostas Georgiadis, @.***> wrote:

Hello,

thank you for your work on this.

I'm using this test runner without issues after having bumped doo minor version. I've also added firefox support which can be convenient for cross browser testing. Latest versions of Chrome and FF are working fine at the moment. Is it ok to create a PR with those two changes: master...kongeor:cljs-test-runner:master https://github.com/Olical/cljs-test-runner/compare/master...kongeor:cljs-test-runner:master

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/Olical/cljs-test-runner/issues/41, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACM6XOFWCDYD4VN7W3RBMDWJKC4BANCNFSM6AAAAAASGANBVE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Olical commented 7 months ago

Upgraded, noted in changes, packaged and deployed! Thanks for improving things and sorry again for letting this slip through the cracks.