search

Olical / cljs-test-runner

Discover and run your ClojureScript tests
https://clojars.org/olical/cljs-test-runner
The Unlicense
86 stars 16 forks source link

Exit code is always zero? #8

Closed arichiardi closed 6 years ago

arichiardi commented 6 years ago

Hi @Olical!

Using your tool way more seriously now :smile:

I noticed that looks like the exit code when tests are failing is still zero. Is there an option I need to enable to report a failure?

To be more clear, the call clojure -m cljs-test-runner.main is the one returning zero.

arichiardi commented 6 years ago

I have added:

(finally
        (println "#############" @exit-code)
        (exit @exit-code))

and it prints ############# 0 out.

arichiardi commented 6 years ago

This is a surprising-to-me node known behavior.

I discovered it the hard way I guess: https://medium.com/@dtinth/making-unhandled-promise-rejections-crash-the-node-js-process-ffc27cfcc9dd

Closing and sorry for the noise.

Olical commented 6 years ago

Not a problem, glad you solved it! :)

On Thu, 5 Jul 2018, 23:14 Andrea Richiardi, notifications@github.com wrote:

Closed #8 https://github.com/Olical/cljs-test-runner/issues/8.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Olical/cljs-test-runner/issues/8#event-1719126572, or mute the thread https://github.com/notifications/unsubscribe-auth/AATPXefX8tg9sw2Foi3uyvyCSAYRjfovks5uDo_YgaJpZM4VEkzy .