search

Olical / depot

Find newer versions of your dependencies in your deps.edn file
https://clojars.org/olical/depot
The Unlicense
258 stars 14 forks source link

Version checking thinks "RELEASE" is not up-to-date #11

Closed seancorfield closed 3 years ago

seancorfield commented 5 years ago

This is kind of a follow on from #7 but for the checking side of Depot, rather than the updating side: the version checker reports that "RELEASE" is out of date compared to whatever the latest stable release actually is.

As noted in that other ticket, we only use "RELEASE" for dev/test tooling where we always want to ensure we're always on the most recent release, without needing any manual process to update dependencies.

Olical commented 5 years ago

Did this go away when you tried out one of the newer master commits for v2.0.0, out of interest?

seancorfield commented 5 years ago

Hard to tell -- v2 doesn't work with our work repo setup!

seancorfield commented 5 years ago

I just noticed that :override-deps and :extra-deps are being included in the latest commit (not sure if the user-level deps is being read tho'?), so I've pulled the latest Depot (and removed my workarounds first!) and I'm re-running my test to see if the overrides work now.

If that works, I'll go over our dev tooling and see if we still use RELEASE and then re-check this.

seancorfield commented 5 years ago

No, it does not work yet. It is not paying any attention to the user-level deps.edn file, as far as I can tell.

Olical commented 4 years ago

Sorry I completely forgot about this issue and the changes @lverns submitted, I need to get this across the line really so the master branch has a released tag. Wondering what needs to be done to finish it off, guessing it's still an issue?

seancorfield commented 4 years ago

It's no longer an issue for me -- I no longer use Depot.

Olical commented 4 years ago

Completely understandable! :smile: this tool definitely needs some love, just got to find the time and energy to do it. I'll leave this open as a note for now, would be worth bearing in mind with any changes or rewrites.

seancorfield commented 4 years ago

In case you're curious, I ended up doing it via a fairly simple shell script that ran clojure -Stree on my code and edited the output into a new deps.edn in a temp folder with "RELEASE" in place of the actual versions, then ran clojure -Stree on that "project" and compared the output with the original deps tree (I can filter deps by depth so I can exclusive some or all transient deps).

Olical commented 4 years ago

Oooo I really like that! Thanks for the tip!

On Tue, 26 May 2020, 16:32 Sean Corfield, notifications@github.com wrote:

In case you're curious, I ended up doing it via a fairly simple shell script that ran clojure -Stree on my code and edited the output into a new deps.edn in a temp folder with "RELEASE" in place of the actual versions, then ran clojure -Stree on that "project" and compared the output with the original deps tree (I can filter deps by depth so I can exclusive some or all transient deps).

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Olical/depot/issues/11#issuecomment-634100093, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACM6XPXSCHI3AMUKZDKUMTRTPOIBANCNFSM4GFGNF2A .