Olical / depot

Find newer versions of your dependencies in your deps.edn file
https://clojars.org/olical/depot
The Unlicense
260 stars 14 forks source link

Handle empty coordinate maps #31

Closed lverns closed 5 years ago

lverns commented 5 years ago

Includes the single commit from #29.

Fixes #30.

Given deps.edn as per the bug report:

{:deps {org.clojure/clojure {}}
 :aliases {:newer-stuff
           {:override-deps {org.clojure/clojure {:mvn/version "1.10.0"}}}}}

Invoking depot with no args prints:

Checking for old versions in: deps.edn
  All up to date!

Invoking with --write

Updating old versions in: deps.edn
  All up to date!

and leaves the file unchanged.


Invoking with --every:

Checking for old versions in: deps.edn
  org.clojure/clojure {:mvn/version "1.10.0"} -> {:mvn/version "1.10.1"}

Invoking with --every and --write:

Updating old versions in: deps.edn
  org.clojure/clojure {:mvn/version "1.10.0"} -> {:mvn/version "1.10.1"}

and the file is now

{:deps {org.clojure/clojure {}}
 :aliases {:newer-stuff
           {:override-deps {org.clojure/clojure {:mvn/version "1.10.1"}}}}}
Olical commented 5 years ago

Awesome stuff! I'll review and merge at some point soon :smile:

Olical commented 5 years ago

I was thinking this would fix all of Sean's woes but I think this one persists :thinking: I'll have to try it myself https://github.com/Olical/depot/issues/11#issuecomment-530948726

Olical commented 5 years ago

Thank you very much for the fixes! :D