search

Olical / react-faux-dom

DOM like structure that renders to React (unmaintained, archived)
http://oli.me.uk/2015/09/09/d3-within-react-the-right-way/
The Unlicense
1.21k stars 87 forks source link

support d3.selection.clone #143

Closed xiechao06 closed 5 years ago

xiechao06 commented 5 years ago

since there's no clone method in d3-seletion@1.0.1, so I upgrade it, besides I tested d3@5.7, all tests passed, so I upgrade its version.

Olical commented 5 years ago

Oh cool, thank you for the contribution! I'll take a look as soon as I get some free time.

I'd quite like to reset that package.lock change though, it's a 2000 line diff because npm has changed all of the resolved URLs to cnpm :sweat_smile: I suspect that's just because of your local npm config though, I should be able to reset that easily enough.

xiechao06 commented 5 years ago

@Olical I've reset the package-lock.json, I upgrade d3 (and modules under it are affected also) and d3-selection, I checked the package-lock.json, some packages add optional: true, hope it doesn't matter. d3@4 should still work (though tests about cloneNode won't pass), but I think it doesn't matter to upgrade the devDependencies, since there's no good way to test in multiple versions of a dependency in npm. https://github.com/npm/npm/issues/5499

Olical commented 5 years ago

Looks good, I'll get it released, thank you very much!