Olink
commented
11 years ago Some things: 1)What happened to the configs in the third commit, i see them deleted but never newed up. 2)Your check for banned items will be setting buffs every 20ms or something like that. You should probably have two different datetime objects for last banned/last warned.
Some things, since its been a while since I last developed for this plugins, that im considering changing now are: Creating a "region object" for each flag, that will know how to deal with its conditions, so if the region is a time based hurt zone, then it would know how to get the players currently inside its region and hurt them. This would be sort of a mini plugin system inside of the plugin, so that other developers can simply extend this plugin with a new one or something along those lines. Another thing is serializing regions to json and dumping that in the db instead of havign all sorts of fields in the db, this way we could just have each region treated as all of the above, but only do something if its flag is enabled. This would also allow us to ditch the bit field and just go for a generic 1-100000 enum sort of thing.
With that being said, I'm not entirely sure how I want to go about this pr. I guess i would double check that all regions still work, that theres not much lag with your new addition, and make both a warning/debuff datetime thingy.
QuiCM
Well, it's been a month or two but I finally found time and fixed it. No flat files! All databasified, with commands in-game to add items to the region's list, as well as commands to remove from the list and to check the list for each region