search

Olipro / PZHook

Java Hook for Project Zomboid
6 stars 1 forks source link

MacOS build broken #2

Open einsweniger opened 1 year ago

einsweniger commented 1 year ago

Hi there! Thank you for starting this. I've tested your MacOS build, it seems like the signature is broken. Or at least, that's what I'm getting from the error.

image

I've run the build on my computer, but it also produces a broken executable signature for the package. Is the build logic modifying files after they were packaged? I guess somewhere in between the jpackage and zipjpackage targets.

Aside from that, I've already found some issues, one of them is going to be this:

https://github.com/Olipro/PZHook/blob/3fbaa1595cc42c2acca34b3f298abb28e1c9710f/src/main/java/ZomboidJavaHook/installer/HookInstaller.java#L119:L125

pretty sure that's not going to work on linux, either. Are you interested in receiving PRs for better Lunix support?

Olipro commented 1 year ago

I don't know why I didn't see this until now :(

I didn't do any work to produce a signature for Mac OS (since I don't have a key for that purpose anyway) - I suspect that what it thinks is a valid signature is just random garbage, but feel free to inspect the gradle build process.

As for the executable patch - that should only get called for the Windows platform.

PRs welcome.