OliveStudio / olivemenus

A powerful menus plugin for Craft CMS built for the need of simplicity and flexibility
MIT License
40 stars 22 forks source link

Is there a way that you can assign a menu item to open in a new tab? #32

Closed rsi2940 closed 4 years ago

rakesmh14 commented 4 years ago

Hello, I have included target option for menu items. I hope this will help you to achieve open in new tab feature. https://github.com/rakesmh14/olivemenus

target-options

Frontend:

target-option-fe

Thank you!

alinistrate commented 4 years ago

@rakesmh14

Thank you. I merged the pull request.

Alin

rsi2940 commented 4 years ago

Thanks for the change. When will the update available to the Craft plugin store? Current change log on craft plugin store only shows up to v1.0.9

alinistrate commented 4 years ago

Hi Rishi,

This was fixed. It should be version 1.1.1 now.

THanks, Alin


From: Rishi Khatiwada notifications@github.com Sent: Monday, February 10, 2020 10:04 PM To: OliveStudio/olivemenus olivemenus@noreply.github.com Cc: Alin Istrate alin.istrate@olivestudio.net; State change state_change@noreply.github.com Subject: Re: [OliveStudio/olivemenus] Is there a way that you can assign a menu item to open in a new tab? (#32)

Thanks for the change. When will the update available to the Craft plugin store? Current change log on craft plugin store only shows up to v1.0.9

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/OliveStudio/olivemenus/issues/32?email_source=notifications&email_token=ABGOJUPU242VK5KUSXDHHPDRCGXMJA5CNFSM4J2REOL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELKBSFI#issuecomment-584325397, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGOJUJHACTAUYC2SOH3YV3RCGXMJANCNFSM4J2REOLQ.

rsi2940 commented 4 years ago

Olivemenus updated to version 1.1.1, now I can add a new menu but all the existing menus are now broken here is a screenshot of the new menu 'test' with 'menu item' and a screenshot of the broken existing menu. Looks like it allows to create a new menu, but not able to edit the existing one. Using Craft v3.4.5 image (creating new menu works) image (editing existing menu breaks)